feat: developer tools page, auto-test orchestrator, BIP display, tests redesign
Bundles several feature streams that have been iterating on the working tree: - Developer Tools page (Debug-only via DEVELOPER_TOOLS symbol): hosts the identification card, manual KWP write + transaction log, ROM/EEPROM dump card with progress banner and completion message, persisted custom-commands library, persisted EEPROM passwords library. New service primitives: IKwpService.SendRawCustomAsync / ReadEepromAsync / ReadRomEepromAsync. Persistence mirrors the Clients XML pattern in two new files (custom_commands.xml, eeprom_passwords.xml). - Auto-test orchestrator (IAutoTestOrchestrator + AutoTestState): linear K-Line read -> unlock -> bench-on -> test sequence with snackbar UI and progress dialog VM, gated on dashboard alarms. - BIP-STATUS display: BipDisplayViewModel + BipDisplayView, RAM read at 0x0106 via IKwpService.ReadBipStatusAsync; status definitions in BipStatusDefinition. - Tests page redesign: TestSectionCard + PhaseTileView replacing the old TestPlanView/TestRunningView/TestDoneView/TestPreconditionsView/ TestSectionView controls and their VMs. - Pump command sliders: Fluent thick-track style with overhang thumb, click-anywhere-and-drag, mouse-wheel adjustment. - Window startup: app.manifest declares PerMonitorV2 DPI awareness, MainWindow installs a WM_GETMINMAXINFO hook in OnSourceInitialized and maximizes there (after the hook is in place) so the app fits the work area exactly on any display configuration. - Misc: PercentToPixelsConverter, seed_aliases.py one-shot pump-alias importer, tools/Import-BipStatus.ps1, kline_eeprom_spec.md and dump-functions reference docs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -119,6 +119,35 @@ namespace HC_APTBS.ViewModels
|
||||
}
|
||||
|
||||
_bench.SetRelay(RelayNames.OilPump, value);
|
||||
|
||||
// The dialog's ShowDialog call runs a nested dispatcher message pump.
|
||||
// While it was blocking, RefreshFromTick may have fired and written
|
||||
// _isOilPumpOn back to the stale relay.State value (false, because
|
||||
// SetRelay above hadn't run yet). Re-assert the backing field now
|
||||
// that relay.State is committed so IsOilPumpOn reports the correct
|
||||
// value to callers downstream (e.g. TestsPageViewModel.StartTestAsync
|
||||
// which guards on it right after this setter returns).
|
||||
// See docs/gotcha-oil-pump-dialog-race.md.
|
||||
if (_isOilPumpOn != value)
|
||||
{
|
||||
_isOilPumpOn = value;
|
||||
OnPropertyChanged(nameof(IsOilPumpOn));
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Energises the oil-pump relay and flags <see cref="IsOilPumpOn"/> without
|
||||
/// presenting the leak-check confirmation dialog. Used by the Dashboard
|
||||
/// "Connect & Auto Test" flow when the operator has opted in via
|
||||
/// <see cref="AppSettings.AutoTestSkipsOilPumpConfirm"/>. Writes the backing
|
||||
/// field directly to avoid re-entering <see cref="OnIsOilPumpOnChanged"/>.
|
||||
/// </summary>
|
||||
public void TurnOilPumpOnSilent()
|
||||
{
|
||||
if (_isOilPumpOn) return;
|
||||
_bench.SetRelay(RelayNames.OilPump, true);
|
||||
_isOilPumpOn = true;
|
||||
OnPropertyChanged(nameof(IsOilPumpOn));
|
||||
}
|
||||
|
||||
// ── RPM commands ──────────────────────────────────────────────────────────
|
||||
@@ -230,12 +259,23 @@ namespace HC_APTBS.ViewModels
|
||||
// ── Refresh (called from MainViewModel timer tick) ────────────────────────
|
||||
|
||||
/// <summary>
|
||||
/// Updates live counter readback from CAN.
|
||||
/// Updates live counter readback from CAN, and mirrors the oil-pump relay
|
||||
/// state so this VM's <see cref="IsOilPumpOn"/> stays in sync even when the
|
||||
/// relay is toggled outside the manual Bench page (e.g. the Dashboard
|
||||
/// auto-test orchestrator). Writes through the backing field to avoid
|
||||
/// re-triggering the confirmation dialog in <see cref="OnIsOilPumpOnChanged"/>.
|
||||
/// Called on the UI thread from <see cref="MainViewModel.OnRefreshTick"/>.
|
||||
/// </summary>
|
||||
public void RefreshFromTick()
|
||||
{
|
||||
BenchCounterValue = _bench.ReadBenchParameter(BenchParameterNames.BenchCounter);
|
||||
|
||||
bool relayOn = _config.Bench.Relays.TryGetValue(RelayNames.OilPump, out var oilRelay) && oilRelay.State;
|
||||
if (_isOilPumpOn != relayOn)
|
||||
{
|
||||
_isOilPumpOn = relayOn;
|
||||
OnPropertyChanged(nameof(IsOilPumpOn));
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user