Before this fix, StartUnlockIfRequired was called immediately after
registering the pump's CAN parameters, before any frames had been
decoded. The TestUnlock parameter's zero-initialised Value was
interpreted as "unlocked" for Type 1 pumps, causing Phase 1 to be
skipped and UnlockCompleted(true) to fire falsely.
Changes:
- ICanService: add IsPumpAlive property (volatile-backed in PcanAdapter)
- PcanAdapter: implement IsPumpAlive; mark _pumpAlive/_benchAlive volatile
for safe cross-thread reads
- MainViewModel: replace direct StartUnlockIfRequired call with a
fire-and-forget WaitForPumpCanThenUnlockAsync that waits for
PumpLivenessChanged(true) + 250 ms grace, then invokes unlock on the
UI thread; cancellation on pump change or CAN disconnect via
_pumpLivenessCts
- UnlockService.UnlockAsync: skip Phase 2 state-machine when observer
seed already reports unlocked (senders still run to prevent re-lock)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
LucianoDev
da0581967b