LucianoDev da0581967b fix: gate Ford VP44 unlock on CAN liveness to prevent false-unlocked reads
Before this fix, StartUnlockIfRequired was called immediately after
registering the pump's CAN parameters, before any frames had been
decoded. The TestUnlock parameter's zero-initialised Value was
interpreted as "unlocked" for Type 1 pumps, causing Phase 1 to be
skipped and UnlockCompleted(true) to fire falsely.

Changes:
- ICanService: add IsPumpAlive property (volatile-backed in PcanAdapter)
- PcanAdapter: implement IsPumpAlive; mark _pumpAlive/_benchAlive volatile
  for safe cross-thread reads
- MainViewModel: replace direct StartUnlockIfRequired call with a
  fire-and-forget WaitForPumpCanThenUnlockAsync that waits for
  PumpLivenessChanged(true) + 250 ms grace, then invokes unlock on the
  UI thread; cancellation on pump change or CAN disconnect via
  _pumpLivenessCts
- UnlockService.UnlockAsync: skip Phase 2 state-machine when observer
  seed already reports unlocked (senders still run to prevent re-lock)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-22 16:52:16 +02:00
2026-04-11 12:45:18 +02:00
2026-04-11 12:45:18 +02:00
2026-04-11 12:45:18 +02:00
2026-04-11 12:45:18 +02:00

HC_APTBS

WPF desktop application for controlling a VP44 diesel injection pump test bench.

Features

  • CAN bus communication — reads/writes bench sensors (temperature, RPM, flow) via PCAN-Basic at 500 kbps
  • K-Line / KWP2000 — communicates with the VP44 pump ECU via FTDI USB adapter at 9600 bps
  • Automated test sequences — runs multi-phase tests with PID temperature control
  • PDF reports — generates test result reports with QuestPDF

Requirements

  • Windows 10/11 (x64)
  • .NET 10 SDK (version pinned in global.json)
  • Hardware: PCAN-USB adapter, FTDI USB-to-serial adapter

Build

dotnet build -r win-x64

Native DLLs (PCANBasic.dll, ftd2xx.dll) are bundled in Resources/Native/ and copied to output automatically.

Stack

Layer Technology
UI WPF / XAML
MVVM CommunityToolkit.Mvvm
DI Microsoft.Extensions.DependencyInjection
Charts LiveCharts2 (SkiaSharp)
PDF QuestPDF 2025.3.2
CAN PCAN-Basic (P/Invoke)
K-Line FTDI D2XX (P/Invoke)

Project Structure

Infrastructure/
  Pcan/          — CAN bus adapter, OEM legitimation, sensor decoding
  Kwp/           — FTDI interface, KWP/KW1281 protocol, 5-baud slow-init
  Logging/       — Daily rotating log files
Services/Impl/   — Test orchestration, KWP operations, config persistence, PDF
ViewModels/      — MVVM view models (ObservableProperty / RelayCommand)
Views/           — Pure XAML views
Models/          — Domain models and test definitions
Description
No description provided
Readme 79 MiB
Languages
C# 98.7%
PowerShell 0.8%
Python 0.5%